markusthoemmes commented on issue #2595: Move variable limits to 
ansible/group_vars/all
URL: 
https://github.com/apache/incubator-openwhisk/pull/2595#issuecomment-321205615
 
 
   @ningyougang it is key though, that you are able to override limits in an 
environment, which is why the `defaultLimits` are global and `limits` are 
"local". I agree the existing scheme isn't perfect, in fact it is quite wrong 
with the recent changes now.
   
   What we should do:
   1. Remove `defaultLimits`, have only `limits`
   2. Make each key in `limits` overridable, such as
   
   ```
   limits:
     invocationsPerMinute: "{{ limit_invocations_per_minute | default(120) }}"
     concurrentInvocations: "{{ limit_invocations_concurrent | default(100) }}"
     concurrentInvocationsSystem:  "{{ limit_invocations_concurrent_system | 
default(5000) }}"
     firesPerMinute: "{{ limit_fires_per_minute | default(60) }}"
     sequenceLength: "{{ limit_sequence_length | default(50) }}"
   ```
   
   That is: It adjusts the wording to conform with the `UserLimits` class. It 
also allows selective overriding per environment (by defining one of the 
`limit_...` variables), but keeps defaults up top.
   
   What do you think?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to