drcariel commented on a change in pull request #2591: User-Agent CLI/version 
header
URL: 
https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r132290510
 
 

 ##########
 File path: tools/cli/go-whisk-cli/main.go
 ##########
 @@ -48,6 +48,7 @@ func init() {
 
     // Rest of CLI uses the Properties struct, so set the build time there
     commands.Properties.CLIVersion = CLI_BUILD_TIME
+    os.Setenv("CLI_Version", CLI_BUILD_TIME)
 
 Review comment:
   I would either need to inject the CLIVersion properly into 
```go-whisk-cli/commands/property.go``` then import this into 
```go-whisk/whisk/client.go```, or just import ```cli/go-whisk-cli/main.go``` 
into ```/cli/go-whisk/whisk/client.go```...?
   
   Not the greatest options imo
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to