rabbah commented on a change in pull request #2591: User-Agent CLI/version
header
URL:
https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r132698730
##########
File path:
core/controller/src/main/scala/whisk/core/controller/WebActions.scala
##########
@@ -326,7 +326,7 @@ trait WhiskWebActionsApi
private val defaultCorsResponse = List(
`Access-Control-Allow-Origin`(AllOrigins),
`Access-Control-Allow-Methods`(OPTIONS, GET, DELETE, POST, PUT, HEAD,
PATCH),
- `Access-Control-Allow-Headers`(`Authorization`.name,
`Content-Type`.name))
+ `Access-Control-Allow-Headers`(`Authorization`.name,
`Content-Type`.name, `User-Agent`.name))
Review comment:
But the controller does nothing with these user agents for POST. And
accepting it here for web actions is just for preflight - I suppose it's fine
(but for the cli this has no value there). If you want to keep it I think we
need a doc update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
