mdeuser commented on a change in pull request #2591: User-Agent CLI/version 
header
URL: 
https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r132710795
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/RestAPIs.scala
 ##########
 @@ -121,7 +121,7 @@ protected[controller] object RestApiCommons {
  */
 protected[controller] trait RespondWithHeaders extends Directives {
     val allowOrigin = `Access-Control-Allow-Origin`(AllOrigins)
-    val allowHeaders = `Access-Control-Allow-Headers`("Authorization", 
"Content-Type")
+    val allowHeaders = `Access-Control-Allow-Headers`("Authorization", 
"Content-Type", "User-Agent")
 
 Review comment:
   if the controller log the user agent header, log queries can see which 
clients and which client versions are accessing the controller.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to