rabbah commented on a change in pull request #2604: (WIP) Give more information 
in Activation lists
URL: 
https://github.com/apache/incubator-openwhisk/pull/2604#discussion_r132737302
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/entity/WhiskActivation.scala
 ##########
 @@ -62,7 +62,8 @@ case class WhiskActivation(
     version: SemVer = SemVer(),
     publish: Boolean = false,
     annotations: Parameters = Parameters(),
-    duration: Option[Long] = None)
+    duration: Option[Long] = None,
+    entityType: String)
 
 Review comment:
   no no no - we are not doing that.
   
   1. action activations have an end and duration.
   2. triggers have no end or duration.
   3. rules have no end or duration, but have a caused field.
   
   you can recover the type this way.
   
   furthermore - your change will break against a production deployment because 
it's a schema change.
   since it's not necessary i won't expand on how to deal with that here.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to