rabbah commented on a change in pull request #2604: (WIP) Give more information 
in Activation lists
URL: 
https://github.com/apache/incubator-openwhisk/pull/2604#discussion_r132738116
 
 

 ##########
 File path: ansible/files/whisks_design_document_for_activations_db.json
 ##########
 @@ -2,7 +2,7 @@
   "_id": "_design/whisks",
   "views": {
     "all": {
-      "map": "function (doc) {\n  var PATHSEP = \"/\";\n  var isActivation = 
function (doc) { return (doc.activationId !== undefined) };\n  var collection = 
function (doc) {\n    if (isActivation(doc)) return \"activations\";\n    
return \"??\";\n  };\n\n  if (isActivation(doc)) try {\n    var ns = 
doc.namespace.split(PATHSEP);\n    var root = ns[0]; ns.shift();\n    var type 
= collection(doc);\n    var date = new Date(doc.start || doc.updated);\n    var 
value = {collection: type, namespace: doc.namespace, name: doc.name, version: 
doc.version, publish: doc.publish, annotations: doc.annotations};\n    
value.activationId = doc.activationId;\n    emit([root, date], value);\n  } 
catch (e) {}\n}\n"
+      "map": "function (doc) {\n  var PATHSEP = \"/\";\n  var isActivation = 
function (doc) { return (doc.activationId !== undefined) };\n  var collection = 
function (doc) {\n    if (isActivation(doc)) return \"activations\";\n    
return \"??\";\n  };\n\n  if (isActivation(doc)) try {\n    var ns = 
doc.namespace.split(PATHSEP);\n    var root = ns[0]; ns.shift();\n    var type 
= collection(doc);\n    var date = new Date(doc.start || doc.updated);\n    var 
value = {collection: type, namespace: doc.namespace, name: doc.name, version: 
doc.version, publish: doc.publish, annotations: doc.annotations, entityType: 
doc.entityType};\n    value.activationId = doc.activationId;\n    emit([root, 
date], value);\n  } catch (e) {}\n}\n"
 
 Review comment:
   let's avoid any changes to the activation view unless there's a very good 
reason for it.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to