csantanapr commented on issue #2605: experimental web apigw cleanup
URL: 
https://github.com/apache/incubator-openwhisk/pull/2605#issuecomment-321922551
 
 
   David what you have is not directly related to apigateway.
   This PR has two concepts that should be split.
   1. apigateway experimental v1
   2. `/experimental/web`  was the first implementation on what we talk today 
as web actions.
   
   I think @rabbah would be happy to see `/experimental/web` removed. ? 
   I would delegate to him on to review and assist on this PR. ? 
   
   I would suggest since the majority of this PR is related to 
`experimental/web` create a new PR and move the changes to the apigateway.md to 
a new PR, that's the only  related change to apigateway in this PR.
   
   Then on the new PR for the ansible:
   1. remove `apigw_host: "http://{{ groups['apigateway']|first 
}}:{{apigateway.port.api}}/v1"`
   all the environments group vars
   2. remove from whisk.properties ansible template 
https://github.com/apache/incubator-openwhisk/blob/master/ansible/templates/whisk.properties.j2#L103
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to