rabbah commented on a change in pull request #2218: Port Controller from Spray
to Akka
URL:
https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814179
##########
File path:
tests/src/test/scala/whisk/core/controller/test/AuthenticateTests.scala
##########
@@ -113,61 +108,22 @@ class AuthenticateTests extends ControllerTestCommon
with Authenticate {
it should "not authorize when malformed user is provided" in {
implicit val tid = transid()
- val pass = UserPass("x", Secret().asString)
+ val pass = BasicHttpCredentials("x", Secret().asString)
val user = Await.result(validateCredentials(Some(pass)), dbOpTimeout)
user should be(None)
}
it should "not authorize when malformed secret is provided" in {
implicit val tid = transid()
- val pass = UserPass(UUID().asString, "x")
+ val pass = BasicHttpCredentials(UUID().asString, "x")
val user = Await.result(validateCredentials(Some(pass)), dbOpTimeout)
user should be(None)
}
it should "not authorize when malformed creds are provided" in {
implicit val tid = transid()
- val pass = UserPass("x", "y")
+ val pass = BasicHttpCredentials("x", "y")
val user = Await.result(validateCredentials(Some(pass)), dbOpTimeout)
user should be(None)
}
}
-
-class AuthenticatedRouteTests
- extends ControllerTestCommon
- with Authenticate
- with AuthenticatedRoute
- with TransactionCounter {
-
- behavior of "Authenticated Route"
-
- val route = sealRoute {
- implicit val tid = transid()
- handleRejections(BasicHttpService.customRejectionHandler) {
- path("secured") {
- authenticate(basicauth) {
- user => complete("ok")
- }
- }
-
- }
- }
-
Review comment:
what are we losing by removing these tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
