rabbah commented on a change in pull request #2595: Remove defaultLimits and
have limits only
URL:
https://github.com/apache/incubator-openwhisk/pull/2595#discussion_r132830286
##########
File path: tests/src/test/scala/limits/ThrottleTests.scala
##########
@@ -65,9 +65,9 @@ class ThrottleTests
val throttleWindow = 1.minute
- val maximumInvokesPerMinute =
getLimit("defaultLimits.actions.invokes.perMinute",
"limits.actions.invokes.perMinute")
- val maximumFiringsPerMinute =
getLimit("defaultLimits.triggers.fires.perMinute",
"limits.triggers.fires.perMinute")
- val maximumConcurrentInvokes =
getLimit("defaultLimits.actions.invokes.concurrent",
"limits.actions.invokes.concurrent")
+ val maximumInvokesPerMinute = getLimit("limits.actions.invokes.perMinute",
null)
Review comment:
I suggest you change the impl of `getLimit` in this class and drop the
`null` argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
