rabbah commented on a change in pull request #2602: Remove old invoker code and
refactor accordingly.
URL:
https://github.com/apache/incubator-openwhisk/pull/2602#discussion_r133492044
##########
File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala
##########
@@ -222,7 +222,15 @@ class InvokerReactive(config: WhiskConfig, instance:
InstanceId, producer: Messa
activationFeed ! MessageFeed.Processed
ack(msg.transid, activation, msg.rootControllerIndex)
store(msg.transid, activation)
+ Future.successful(())
}
+ }.recoverWith {
+ case t =>
+ // Iff everything above failed, we have a terminal error
at hand. Either the message failed
+ // to deserialize, or something threw an error where it is
not expected to throw.
+ activationFeed ! MessageFeed.Processed
Review comment:
good catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
