csantanapr commented on a change in pull request #2429: adding param for
install catalog
URL:
https://github.com/apache/incubator-openwhisk/pull/2429#discussion_r133565637
##########
File path: ansible/tasks/installOpenwhiskCatalog.yml
##########
@@ -29,6 +30,6 @@
version: "{{ version }}"
- name: install the catalog from the catalog location
- shell: ./installCatalog.sh {{ catalog_auth_key }} {{ api_host }} {{
catalog_namespace }} {{ cli.path }} chdir="{{ catalog_location }}/packages"
+ shell: ./installCatalog.sh {{ catalog_auth_key }} {{ api_host }} {{
catalog_namespace }} {{ cli.path }} {{ whisk_api_host }} chdir="{{
catalog_location }}/packages"
Review comment:
instead use `whisk_api_host_name` and not create a new one, even if it's
local to this file. change would be to:
```
shell: ./installCatalog.sh {{ catalog_auth_key }} {{ api_host }} {{
catalog_namespace }} {{ cli.path }} {{ whisk_api_host_name | groups['edge'] |
first }} chdir="{{ catalog_location }}/packages"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
