akrabat commented on a change in pull request #2646: Content type header
improvements
URL:
https://github.com/apache/incubator-openwhisk/pull/2646#discussion_r133987369
##########
File path:
tests/src/test/scala/whisk/core/controller/test/WebActionsApiTests.scala
##########
@@ -890,7 +998,7 @@ trait WebActionsApiTests extends ControllerTestCommon with
BeforeAndAfterEach wi
invocationsAllowed += 1
actionResult = Some(JsObject(
"headers" -> JsObject(
- "content-type" -> "xyz/bar".toJson),
+ "content-type" -> "xyzbar".toJson),
Review comment:
> Is this related to the removal of getForKey above?
yes - `getForKey()` tests that the media type is known to Akka-Http which
isn't very useful there are a lot of media types are not in their list. Hence I
changed `findContentTypeInHeader` to only do the `parse()` which ensures that
it the format is valid, but not do the check against the list Akka-Http knows
about.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
