markusthoemmes commented on a change in pull request #2624: Add cache
invalidation between controllers
URL:
https://github.com/apache/incubator-openwhisk/pull/2624#discussion_r134218215
##########
File path:
core/controller/src/main/scala/whisk/core/controller/Controller.scala
##########
@@ -96,6 +98,8 @@ class Controller(
private implicit val authStore = WhiskAuthStore.datastore(whiskConfig)
private implicit val entityStore = WhiskEntityStore.datastore(whiskConfig)
private implicit val activationStore =
WhiskActivationStore.datastore(whiskConfig)
+ private val remoteCacheInvalidaton = new
RemoteCacheInvalidation(whiskConfig, "controller", instance)
+ private def changeCacheCallback(key: CacheKey): Future[Unit] =
remoteCacheInvalidaton.notifyOtherInstancesAboutInvalidation(key)
Review comment:
Could we rewrite this as:
```scala
private val changeCacheCallback =
remoteCacheInvalidaton.notifyOtherInstancesAboutInvalidation _
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
