tysonnorris commented on a change in pull request #2650: Apply standard scala
formatting.
URL:
https://github.com/apache/incubator-openwhisk/pull/2650#discussion_r134609003
##########
File path: common/scala/src/main/scala/whisk/common/Config.scala
##########
@@ -42,113 +42,120 @@ import scala.util.Try
* @param optionalProperties a Set of optional properties which may or not be
defined.
* @param env an optional environment to read from (defaults to sys.env).
*/
-class Config(
- requiredProperties: Map[String, String],
- optionalProperties: Set[String] = Set())(
- env: Map[String, String] = sys.env)(
- implicit logging: Logging) {
-
- private val settings = getProperties().toMap.filter {
- case (k, v) => requiredProperties.contains(k) ||
- (optionalProperties.contains(k) && v != null)
- }
+class Config(requiredProperties: Map[String, String], optionalProperties:
Set[String] = Set())(
+ env: Map[String, String] = sys.env)(implicit logging: Logging) {
Review comment:
seems like things are at 2 space indent - can wrapping be the same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
