starpit commented on issue #2660: Reduce Memory Consumption Used to Invoke a Single Action URL: https://github.com/apache/incubator-openwhisk/pull/2660#issuecomment-324175666 i suggest that, before we proceed (and, indeed, for any memory-related change, if not perhaps even for *any* controller change going forwards) that we should collect: at the very least: max heap occupancy for a test which invokes a longish sequence N-way, in parallel. compare this value to that of the current master. very important also: collect a class histogram after completion of the test, say within 30 seconds (very important: less than 5 minutes after test completion), and ensure that the number of WhiskActivation structures is very small; if N threads each execute a sequence of length M, and to his L times, then the number of WhiskActivation structures alive should be close to N-ish, some small multiple of it at worst. ideally, we also want the instantaneous number of JSON structures to be close to N (if that is max concurrency for the load test), and the number should decrease to zero within 10 seconds of test completion. beyond this, we want the number of JSON structures in heap to be constant, independent of the number of concurrently live actors. this will take quite a bit more work, but is probably the single biggest offender. beyond WhiskActivation and JSON structures, we also want to establish the property that the number of code/blob strings in heap is zero. we should get to this point, and write tests that establish the verity of this condition, by using class histogram snapshots taken during such a mild load test run (i.e. we don't need to do a heavy duty load test in order to identify these problems, and to verify that they remain fixed). but it does require some amount of load, i.e. these are just unit tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
