mrutkows commented on a change in pull request #375: Make interative mode able 
to set to false
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/375#discussion_r134835273
 
 

 ##########
 File path: deployers/servicedeployer.go
 ##########
 @@ -119,7 +119,7 @@ func (deployer *ServiceDeployer) ConstructDeploymentPlan() 
error {
 
        manifestReader.InitRootPackage(manifestParser, manifest)
 
-       if deployer.IsDefault == true && !utils.Flags.WithinOpenWhisk {
 
 Review comment:
   I am curious as why we were testing "WithinOpenWhisk" here in the first 
place... 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to