houshengbo commented on a change in pull request #262: Adjust the code to
reflect latest API gateway version.
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/262#discussion_r136593323
##########
File path: deployers/whiskclient.go
##########
@@ -28,166 +28,166 @@ import (
"github.com/apache/incubator-openwhisk-client-go/whisk"
"github.com/apache/incubator-openwhisk-wskdeploy/parsers"
"github.com/apache/incubator-openwhisk-wskdeploy/utils"
- "path"
- "errors"
+ "path"
+ "errors"
)
const (
- COMMANDLINE = "wskdeploy command line"
- DEFAULTVALUE = "default value"
- WSKPROPS = ".wskprops"
- WHISKPROPERTY = "whisk.properties"
- INTERINPUT = "interactve input"
+ COMMANDLINE = "wskdeploy command line"
Review comment:
David, I was wondering what IDE you used to write go code.
As you see, your PR contains a lot of changes regarding indentations like
this, which do not bring any changes. I am using INTELLIJ, and there should be
4 spaces for each indentation. I suspect you use 8 or 7 spaces for each
indentation. If so, would you please change it to 4?
Let's make our dev environment consistent, so that we only submit PRs with
meaningful changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
