tysonnorris commented on a change in pull request #2689: WIP on dynamic invoker
id assignment
URL:
https://github.com/apache/incubator-openwhisk/pull/2689#discussion_r136706180
##########
File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
##########
@@ -89,6 +91,41 @@ object Invoker {
val msgProvider = SpiLoader.get[MessagingProvider]()
val producer = msgProvider.getProducer(config, ec)
+
+ val invokerOrdinal =
+ if (args.length == 0) {
+ val registrationUUID = UUID()
Review comment:
If an invoker restarts on same host should it have a different UUID?
Currently this will orphan messages queued for the ID just before it exited. I
thought that the invoker on same host should have the same instance ID on
restart. This implies that the ID is derived from the host (or cluster of
hosts) somehow - we currently leverage the host IP (encoded as an int) for this
purpose
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
