daisy-ycguo commented on issue #381: Move manifest.yml and manifest.yaml out of integration test URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/381#issuecomment-326860449 @pritidesai I don't quite understand this issue. These four tests invoke the command `wskdeploy` to deploy action (src: `tests/src/integration/flagstests/src/greeting.js`) to OpenWhisk server. I think it's a kind of integration tests not unit test. Because unit test will not set up OpenWhisk server and will not exec the deployment to real OpenWhisk server. What's more, I noticed there were several manifest.yaml and deployment.yaml in sub folders of `tests/src/integration`. Then what's the meaning to only remove manifest.yaml and manifest.yml under folder `tests/src/integration/flagstests/`? if we move these four functions to unit test, how to handle the dependencies to real OpenWhisk server and the source code `tests/src/integration/flagstests/src/greeting.js`? Any suggestions about the changes of test logic ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
