rabbah commented on a change in pull request #2684: Decorate throttled error
response with count/limit.
URL:
https://github.com/apache/incubator-openwhisk/pull/2684#discussion_r137099309
##########
File path: common/scala/src/main/scala/whisk/http/ErrorResponse.scala
##########
@@ -57,10 +57,10 @@ object Messages {
val resourceDoesNotExist = "The requested resource does not exist."
/** Standard message for too many activation requests within a rolling
time window. */
- val tooManyRequests = "Too many requests in a given amount of time for
namespace."
+ def tooManyRequests(count: Int, allowed: Int) = s"Too many requests in the
last minute (count: $count, allowed: $allowed)."
Review comment:
No it's not. It's baked into the rate throttle implementation. I'd consider
doing that (lifting the granularity of the throttle to ansible) separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
