dubeejw commented on a change in pull request #2544: Allow CLI to Save Code
from Action (Review)
URL:
https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r137360021
##########
File path: tools/cli/go-whisk-cli/commands/action.go
##########
@@ -908,29 +1019,29 @@ func init() {
actionCreateCmd.Flags().BoolVar(&flags.action.sequence, "sequence", false,
wski18n.T("treat ACTION as comma separated sequence of actions to invoke"))
actionCreateCmd.Flags().StringVar(&flags.action.kind, "kind", "",
wski18n.T("the `KIND` of the action runtime (example: swift:default,
nodejs:default)"))
actionCreateCmd.Flags().StringVar(&flags.action.main, "main", "",
wski18n.T("the name of the action entry point (function or fully-qualified
method name when applicable)"))
- actionCreateCmd.Flags().IntVarP(&flags.action.timeout, "timeout", "t",
TIMEOUT_LIMIT, wski18n.T("the timeout `LIMIT` in milliseconds after which the
action is terminated"))
- actionCreateCmd.Flags().IntVarP(&flags.action.memory, "memory", "m",
MEMORY_LIMIT, wski18n.T("the maximum memory `LIMIT` in MB for the action"))
- actionCreateCmd.Flags().IntVarP(&flags.action.logsize, "logsize", "l",
LOGSIZE_LIMIT, wski18n.T("the maximum log size `LIMIT` in MB for the action"))
+ actionCreateCmd.Flags().IntVarP(&flags.action.timeout, TIMEOUT_FLAG, "t",
TIMEOUT_LIMIT, wski18n.T("the timeout `LIMIT` in milliseconds after which the
action is terminated"))
Review comment:
I think that change is beyond the scope of this PR as all the flag names
would have to be changed in all the files that provide commands. Will open an
issue since I think consts should be used for flag names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
