tysonnorris commented on a change in pull request #2648: Overhaul logging URL: https://github.com/apache/incubator-openwhisk/pull/2648#discussion_r137381432
########## File path: common/scala/src/main/resources/logback.xml ########## @@ -0,0 +1,16 @@ +<configuration> + <appender name="console" class="ch.qos.logback.core.ConsoleAppender"> Review comment: Recommend an AsyncAppender here; from the docs https://logback.qos.ch/manual/appenders.html > This strategy has an amazingly favorable effect on performance at the cost of event loss. (and its worth adding a comment to the config to advise on the lossy behavior when discarding TRACE/DEBUG/INFO events when writing to stream is backed up to 80% of queue size) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
