bbrowning commented on a change in pull request #1: Moving from 'loadtest' to
'wrk' for better loadtest performance
URL:
https://github.com/apache/incubator-openwhisk-performance/pull/1#discussion_r137515359
##########
File path: tests/throughput.sh
##########
@@ -9,12 +9,22 @@ credentials=$2
# concurrency level of the throughput test: How many requests should
# open in parallel.
concurrency=$3
-# How many samples to create by the test. Default: 10000
-samples=${4:-10000}
+# How many threads to utilize, directly correlates to the number
+# of CPU cores
+threads=${4:-4}
+# How long to run the test
+duration=${5:-30s}
action="noopThroughput"
"$currentDir/create.sh" "$host" "$credentials" "$action"
# run throughput tests
-encodedAuth=$(echo "$credentials" | base64 -w 0)
-docker run --rm markusthoemmes/loadtest loadtest -n "$samples" -c
"$concurrency" -k -m POST -H "Authorization: basic $encodedAuth"
"$host/api/v1/namespaces/_/actions/$action?blocking=true"
\ No newline at end of file
+encodedAuth=$(echo "$credentials" | base64)
Review comment:
At least on my machine (Fedora 25), the `-w 0` option to base64 is still
needed. Otherwise `encodedAuth` ends up with a newline in it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
