mrutkows commented on a change in pull request #465: Use feed in trigger entity
instead of source
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/465#discussion_r137819132
##########
File path: parsers/manifest_parser.go
##########
@@ -384,12 +384,20 @@ func (dm *YAMLParser) ComposeTriggers(manifest
*ManifestYAML) ([]*whisk.Trigger,
pub := false
wsktrigger.Publish = &pub
- keyValArr := make(whisk.KeyValueArr, 0)
+ //print warning information when .Source is not empty
if trigger.Source != "" {
+ fmt.Println("WARNING: The 'source' YAML key in trigger
entity is deprecated. Please use 'feed' instead as described in
specifications.")
Review comment:
@daisy-ycguo can we please use the new Debug method from misc.go?
e.g.,:
```whisk.Debug(whisk.DbgWarn, warningString)``` ?
and please move the warning string to our translation file:
```wski18n/resources/en_US.all.json```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
