dubeejw commented on a change in pull request #214: WIP Support multiple workers
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/214#discussion_r137960795
##########
File path: provider/database.py
##########
@@ -37,9 +37,11 @@ class Database:
filters_design_doc_id = '_design/filters'
only_triggers_view_id = 'only-triggers'
+ by_worker_view_id = 'by-worker'
instance = os.getenv('INSTANCE', 'messageHubTrigger-0')
- canaryId = "canary-{}".format(instance)
+ workerId = os.getenv('WORKER', 'worker0')
Review comment:
Looks like the call to determine the worker occurs in service.py. Instead
value should be determine once and shared between the two classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
