markusthoemmes commented on a change in pull request #2531: Share bookkeeping
data across controllers
URL:
https://github.com/apache/incubator-openwhisk/pull/2531#discussion_r138257547
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
##########
@@ -95,7 +100,12 @@ class LoadBalancerService(config: WhiskConfig, instance:
InstanceId, entityStore
private val blackboxFraction: Double = Math.max(0.0, Math.min(1.0,
config.controllerBlackboxFraction))
logging.info(this, s"blackboxFraction =
$blackboxFraction")(TransactionId.loadbalancer)
- private val loadBalancerData = new LoadBalancerData()
+ /** Feature switch for shared load balancer data **/
+ private val loadBalancerData = {
+ if (config.controllerLocalBookkeeping.equalsIgnoreCase("true")) {
Review comment:
Should we add a `toBoolean` method to `Config.scala` like so:
```scala
def getAsBoolean(key: String, defaultValue: Boolean): Boolean = {
Try(getProperty(key).toBoolean).getOrElse(defaultValue)
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
