rabbah commented on a change in pull request #2714: Disable explicit retry on
container http connection.
URL:
https://github.com/apache/incubator-openwhisk/pull/2714#discussion_r138429538
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/HttpUtils.scala
##########
@@ -133,6 +136,7 @@ protected[core] class HttpUtils(hostname: String, timeout:
FiniteDuration, maxRe
private val connection = HttpClientBuilder.create
.setDefaultRequestConfig(httpconfig)
.useSystemProperties()
+ .disableAutomaticRetries()
Review comment:
we don't use the automatic retries anyway and they don't apply for our
operations which use `POST` that is not idempotent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services