dubeejw commented on a change in pull request #2593: Add BaseWsk class for Wsk
and WskRest to inherit
URL:
https://github.com/apache/incubator-openwhisk/pull/2593#discussion_r138430547
##########
File path: tests/src/test/scala/common/Wsk.scala
##########
@@ -189,10 +127,10 @@ trait ListOrGetFromCollection extends
FullyQualifiedNames {
}
}
-trait DeleteFromCollection extends FullyQualifiedNames {
+trait DeleteFromCollectionCLI extends BaseDeleteFromCollection {
self: RunWskCmd =>
- protected val noun: String
+ override protected val noun: String
Review comment:
Does this value have to be overridden if it is never set in this trait?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
