houshengbo commented on issue #2593: Add BaseWsk class for Wsk and WskRest to 
inherit
URL: 
https://github.com/apache/incubator-openwhisk/pull/2593#issuecomment-329281578
 
 
   @markusthoemmes 
   I tried very hard before to override the Wsk without creating the BaseWsk 
and the other basic entities, but I failed. When REST is implemented by akka 
client, we need to extend FlatSpec and add with WskActorSystem for 
RunWskRestCmd, so that WskRestAction and WskRestPackage can inherit it. 
However, if we extend the current RunWskCmd, it would report a contradiction of 
by adding "FlatSpec" and "WskActorSystem". I have to create a base class and 
the base entities, so both CLI and REST can extend with no conflicts.
   
   If you want to see how it looks like in further PR, go to 
https://github.com/apache/incubator-openwhisk/pull/2589.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to