jthomas commented on a change in pull request #72: Adding type definitions for
typescript
URL:
https://github.com/apache/incubator-openwhisk-client-js/pull/72#discussion_r138839014
##########
File path: package.json
##########
@@ -41,7 +42,9 @@
"proxyquire": "1.7.4"
},
"dependencies": {
- "request-promise": "^2.0.1"
+ "request-promise": "^2.0.1",
+ "@types/node": "^8.0.26",
Review comment:
Does this need to be in "dependencies" rather than "devDependencies"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
