vvraskin commented on a change in pull request #2531: Share bookkeeping data across controllers URL: https://github.com/apache/incubator-openwhisk/pull/2531#discussion_r139291048
########## File path: core/controller/src/main/scala/whisk/core/loadBalancer/SeedNodesProvider.scala ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package whisk.core.loadBalancer + +import akka.actor.Address + +import scala.collection.immutable.Seq + +trait SeedNodesProvider { + def getSeedNodes(): Seq[Address] +} + +class StaticSeedNodesProvider(seedNodes: String, actorSystemName: String) extends SeedNodesProvider { Review comment: I think that passing only what is indeed _needed_ to a method is the right approach in this case, e.g. two strings instead of the overhead of the rest of the whiskConfig and the actor system. It makes it easier to test, so no extra mocking is required. If another implementation would be needed, one could create another class extending `SeedNodesProvider` with custom parameters and no interference. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
