tysonnorris commented on a change in pull request #2531: Share bookkeeping data across controllers URL: https://github.com/apache/incubator-openwhisk/pull/2531#discussion_r139474592
########## File path: core/controller/src/main/scala/whisk/core/loadBalancer/SeedNodesProvider.scala ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package whisk.core.loadBalancer + +import akka.actor.Address + +import scala.collection.immutable.Seq + +trait SeedNodesProvider { + def getSeedNodes(): Seq[Address] +} + +class StaticSeedNodesProvider(seedNodes: String, actorSystemName: String) extends SeedNodesProvider { Review comment: Maybe what isn't clear is that way SPIs work is that the behave as factories, where each impl uses the same interface, so this impl will have to be refactored to become extensible in any way. To prepare for that you would need to have an extra class `StaticSeedNodesProviderFactory` which knows how to construct your `StaticSeedNodesProvider` using that existing constructor - my ask is to create both classes now, so that making it extensible in the future is ONLY a matter of how `StaticSeedNodesProviderFactory` is instantiated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
