jcrossley3 commented on a change in pull request #72: Fix travis builds by
combining PR70 and PR71
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/72#discussion_r145466009
##########
File path: kubernetes/invoker/invoker.yml
##########
@@ -70,6 +70,12 @@ spec:
- name: "INVOKER_INSTANCES"
value: "1"
+ # Invoker assigned name. Derived from hostname
+ - name: "INVOKER_NAME"
+ valueFrom:
+ fieldRef:
+ fieldPath: spec.nodeName
Review comment:
Would `metadata.name` be a better fieldPath? Couldn't there be multiple
invokers on a node? On minikube, for example, `spec.nodeName` returns
`localhost` where `metadata.name` returns `invoker-0`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services