rabbah commented on a change in pull request #2871: Invokers only require Redis
if using dynamic Id assignment
URL:
https://github.com/apache/incubator-openwhisk/pull/2871#discussion_r145507456
##########
File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
##########
@@ -94,6 +94,12 @@ object Invoker {
id
}
.getOrElse {
+ if (config.redisHostName == "" || config.redisHostPort == "") {
Review comment:
`== ""` could be `.isEmpty (or .nonEmpty for the opposite).
trim.isEmpty to avoid blanks?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
