mdeuser commented on a change in pull request #2877: Better error controller
message for authorization failure
URL:
https://github.com/apache/incubator-openwhisk/pull/2877#discussion_r146353816
##########
File path:
core/controller/src/main/scala/whisk/core/entitlement/Entitlement.scala
##########
@@ -193,7 +199,14 @@ protected[core] abstract class
EntitlementProvider(config: WhiskConfig, loadBala
logging.error(this, s"failed while checking entitlement:
${t.getMessage}")
} flatMap { isAuthorized =>
if (isAuthorized) Future.successful({})
- else Future.failed(RejectRequest(Forbidden))
+ else
+ Future.failed(
+ RejectRequest(
+ Forbidden,
+ Some(
+ ErrorResponse(
+ Messages.notAuthorizedtoAccessResource(resources.map(r =>
r.fqname).mkString(", ")),
+ transid))))
Review comment:
yep. i wanted to only include the specific resource(s) in the set that were
not accessible, but, as you mentioned, the lower level method performing the
access check returned a single boolean as the all-or-nothing accessibility
value. if this is not a common use case, perhaps this message can be left as
it currently is - without naming any particular resource; otherwise, additional
changes will be needed to surface inaccessible resource(s).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services