rabbah commented on a change in pull request #2877: Better error controller
message for authorization failure
URL:
https://github.com/apache/incubator-openwhisk/pull/2877#discussion_r146384623
##########
File path:
core/controller/src/main/scala/whisk/core/entitlement/Entitlement.scala
##########
@@ -193,7 +199,14 @@ protected[core] abstract class
EntitlementProvider(config: WhiskConfig, loadBala
logging.error(this, s"failed while checking entitlement:
${t.getMessage}")
} flatMap { isAuthorized =>
if (isAuthorized) Future.successful({})
- else Future.failed(RejectRequest(Forbidden))
+ else
+ Future.failed(
+ RejectRequest(
+ Forbidden,
+ Some(
+ ErrorResponse(
+ Messages.notAuthorizedtoAccessResource(resources.map(r =>
r.fqname).mkString(", ")),
+ transid))))
Review comment:
You could refactor the individual resource checks and resolve all the
promises later where you can provide the extra information. I think that?s the
sprit if the issue as it would apply to sequences.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
