cbickel commented on a change in pull request #2888: Adapt trigger throttle for 
multiple controllers
URL: 
https://github.com/apache/incubator-openwhisk/pull/2888#discussion_r146486535
 
 

 ##########
 File path: tests/src/test/scala/ha/ShootComponentsTests.scala
 ##########
 @@ -94,9 +94,11 @@ class ShootComponentsTests extends FlatSpec with Matchers 
with WskTestHelpers wi
 
       println(s"Done rerquests with responses: invoke: 
${invokeExit.futureValue} and get: ${getExit.futureValue}")
 
-      // Do at most one action invocation per second to avoid getting 429s. 
(60 req/min - limit)
-      val wait = 1000 - (Instant.now.toEpochMilli - start.toEpochMilli)
-      Thread.sleep(if (wait < 0) 0L else if (wait > 1000) 1000L else wait)
+      // Do at most one action invocation per 2 seconds to avoid getting 429s. 
(30 req/min - half of the limit for
+      // when one controller is down)
+      val period = 2000
 
 Review comment:
   Can we set this parameter dynamically depending on the number of controllers 
in this environment?
   
   Reason is: If we add another controller, we are able to do more requests 
until we get throttled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to