markusthoemmes commented on a change in pull request #2857: Emit metrics via 
kamon
URL: 
https://github.com/apache/incubator-openwhisk/pull/2857#discussion_r146548196
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/common/TransactionId.scala
 ##########
 @@ -55,7 +55,19 @@ case class TransactionId private (meta: 
TransactionMetadata) extends AnyVal {
    */
   def mark(from: AnyRef, marker: LogMarkerToken, message: String = "", 
logLevel: LogLevel = InfoLevel)(
     implicit logging: Logging) = {
-    logging.emit(logLevel, this, from, createMessageWithMarker(message, 
LogMarker(marker, deltaToStart)))
+
+    if (TransactionId.metricsLog) {
+      logging.emit(logLevel, this, from, createMessageWithMarker(message, 
LogMarker(marker, deltaToStart)))
+    } else {
+      if (message.nonEmpty) {
 
 Review comment:
   Also known as 
   
   ```scala
   } else if (message.nonEmpty) {
     ...
   }
   ```
   
   Applies to all occurences.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to