mdeuser commented on a change in pull request #2864: Add the support of
certificate checking for secure mode
URL:
https://github.com/apache/incubator-openwhisk/pull/2864#discussion_r146679311
##########
File path: tools/cli/go-whisk/whisk/client.go
##########
@@ -162,11 +140,43 @@ func NewClient(httpClient *http.Client, config *Config)
(*Client, error) {
return c, nil
}
+func (c *Client) LoadX509KeyPair() error {
+ tlsConfig := &tls.Config {
+ InsecureSkipVerify: c.Config.Insecure,
+ }
+
+ if c.Config.Cert != "" && c.Config.Key != "" {
Review comment:
should a warning/error be returned if the cert is partially configured -
i.e. a key is specified, but not the cert or a cert is specified but not the
key? currently, this incorrect configuration is silently ignored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
