dubeejw commented on a change in pull request #2893: WIP Support retrieving 
status and configuration of feed triggers in CLI
URL: 
https://github.com/apache/incubator-openwhisk/pull/2893#discussion_r149773363
 
 

 ##########
 File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala
 ##########
 @@ -1125,6 +1124,73 @@ class WskBasicUsageTests extends TestHelpers with 
WskTestHelpers {
     }
   }
 
+  it should "invoke a feed action with the correct lifecyle event when 
creating a feed trigger" in withAssetCleaner(
 
 Review comment:
   @rabbah, what are your thoughts on not using the `assetCleaner` to roll 
these three tests into one using something like the below.
   ```
     it should "invoke a feed action with the correct lifecyle event when 
creating, reading, and deleting a feed trigger" in withAssetCleaner(
       wskprops) { (wp, assetHelper) =>
       val actionName = "echo"
       val triggerName = "feedTest"
   
       assetHelper.withCleaner(wsk.action, actionName) { (action, _) =>
         action.create(actionName, 
Some(TestUtils.getTestActionFilename("echo.js")))
       }
   
       try {
         wsk.trigger.create(triggerName, feed = Some(actionName)).
             stdout should include(""""lifecycleEvent": "CREATE"""")
   
         wsk.trigger.get(triggerName).
             stdout should include(""""lifecycleEvent": "READ"""")
       } finally {
         wsk.trigger.delete(triggerName).
             stdout should include(""""lifecycleEvent": "DELETE"""")
       }
     }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to