csantanapr commented on a change in pull request #63: style: add .editorconfig,
eslint and reformat js file
URL:
https://github.com/apache/incubator-openwhisk-client-js/pull/63#discussion_r150382432
##########
File path: README.md
##########
@@ -66,19 +67,19 @@ ow.actions.invoke('sample').then(result =>
console.log(result))
_Client constructor supports the following mandatory parameters:_
- **apihost.** Hostname and optional port for openwhisk platform, e.g.
`openwhisk.ng.bluemix.net` or `my_whisk_host:80`. Used with API URL template
`${protocol}://${apihost}/api/v1/`. If port is missing or port value is 443 in
the apihost string, protocol is HTTPS. Otherwise, protocol is HTTP.
-- **api_key.** Authorisation key for user account registered with OpenWhisk
platform.
+- **apiKey.** Authorisation key for user account registered with OpenWhisk
platform.
Review comment:
Please do not remove the constructor API parameters this will be braking API
change.
Find a way in the linter or code style rule to exclude this
we need to keep the parameter names. It?s ok to add new aliases for the new
names and mark the current ones deprecated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
