csantanapr commented on a change in pull request #143: add parameters as query
parameters for get request
URL:
https://github.com/apache/incubator-openwhisk-package-cloudant/pull/143#discussion_r151301431
##########
File path: actions/changes.js
##########
@@ -30,12 +30,21 @@ function requestHelper(url, input, method) {
return new Promise(function(resolve, reject) {
- request({
+ var options = {
method : method,
url : url,
- json: input,
rejectUnauthorized: false
- }, function(error, response, body) {
+ };
+
+ if (method === 'get') {
+ options.qs = input;
+ options.json = true;
Review comment:
move json: true out to options declaration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services