markusthoemmes commented on a change in pull request #2576: Configure components via pureconfig. URL: https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r151635544
########## File path: ansible/roles/controller/tasks/deploy.yml ########## @@ -72,27 +72,33 @@ "LIMITS_ACTIONS_INVOKES_CONCURRENTINSYSTEM": "{{ limits.concurrentInvocationsSystem }}" "LIMITS_TRIGGERS_FIRES_PERMINUTE": "{{ limits.firesPerMinute }}" "LIMITS_ACTIONS_SEQUENCE_MAXLENGTH": "{{ limits.sequenceMaxLength }}" - "CONTROLLER_BLACKBOXFRACTION": "{{ controller.blackboxFraction }}" - "LOADBALANCER_INVOKERBUSYTHRESHOLD": "{{ invoker.busyThreshold }}" "RUNTIMES_MANIFEST": "{{ runtimesManifest | to_json }}" "CONTROLLER_LOCALBOOKKEEPING": "{{ controller.localBookkeeping }}" - "AKKA_CLUSTER_PORT": "{{ controller.akka.cluster.basePort + groups['controllers'].index(inventory_hostname) }}" - "AKKA_CLUSTER_HOST": "{{ controller.akka.cluster.host[groups['controllers'].index(inventory_hostname)] }}" "AKKA_CLUSTER_SEED_NODES": "{{seed_nodes_list | join(' ') }}" - "AKKA_CLUSTER_BIND_PORT": "{{ controller.akka.cluster.bindPort }}" - "AKKA_ACTOR_PROVIDER": "{{ controller.akka.provider }}" "METRICS_KAMON": "{{ metrics.kamon.enabled }}" "METRICS_LOG": "{{ metrics.log.enabled }}" - "METRICS_KAMON_HOST": "{{ metrics.kamon.host }}" - "METRICS_KAMON_PORT": "{{ metrics.kamon.port }}" "CONTROLLER_HA": "{{ controller.ha }}" + + "METRICS_KAMON": "{{ metrics.kamon.enabled }}" + "METRICS_LOG": "{{ metrics.log.enabled }}" + + "CONFIG_whisk_loadbalancer_invokerBusyThreshold": "{{ invoker.busyThreshold }}" + "CONFIG_whisk_loadbalancer_blackboxFraction": "{{ controller.blackboxFraction }}" + + "CONFIG_akka_actor_provider": "{{ controller.akka.provider }}" + "CONFIG_akka_remote_netty_tcp_hostname": "{{ controller.akka.cluster.host[groups['controllers'].index(inventory_hostname)] }}" + "CONFIG_akka_remote_netty_tcp_port": "{{ controller.akka.cluster.basePort + groups['controllers'].index(inventory_hostname) }}" + "CONFIG_akka_remote_netty_tcp_bindPort": "{{ controller.akka.cluster.bindPort }}" + + "CONFIG_kamon_statsd_hostname": "{{ metrics.kamon.host }}" Review comment: Right. The purpose of those env variables + the transform script is to avoid that double-declaration and pass values through directly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services