rabbah commented on a change in pull request #2878: Streamingly read user-logs.
URL:
https://github.com/apache/incubator-openwhisk/pull/2878#discussion_r152796695
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainer.scala
##########
@@ -17,24 +17,32 @@
package whisk.core.containerpool.docker
-import java.nio.charset.StandardCharsets
import java.time.Instant
+import java.util.concurrent.atomic.AtomicLong
import akka.actor.ActorSystem
+import akka.stream._
+import akka.stream.scaladsl.Framing.FramingException
import spray.json._
-import scala.concurrent.ExecutionContext
-import scala.concurrent.Future
+import scala.concurrent.{ExecutionContext, Future}
import scala.concurrent.duration._
-import scala.util.Failure
import whisk.common.Logging
import whisk.common.TransactionId
import whisk.core.containerpool._
import whisk.core.entity.ActivationResponse.{ConnectionError, MemoryExhausted}
import whisk.core.entity.ByteSize
import whisk.core.entity.size._
+import akka.stream.scaladsl.{Framing, Source}
+import akka.stream.stage._
+import akka.util.ByteString
+import spray.json._
+import whisk.core.containerpool.logging.LogLine
+import whisk.http.Messages
object DockerContainer {
+ // The action proxies inserts this line in the logs at the end of each
activation for stdout/stderr
Review comment:
should qualify the comment that this may not apply to blackbox/docker
actions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
