mdeuser commented on a change in pull request #45: WIP: Adding support for path
parameters for api gateway
URL:
https://github.com/apache/incubator-openwhisk-client-go/pull/45#discussion_r153317535
##########
File path: whisk/api.go
##########
@@ -71,6 +71,32 @@ type Api struct {
GatewayFullPath string `json:"gatewayFullPath,omitempty"`
Swagger string `json:"swagger,omitempty"`
Action *ApiAction `json:"action,omitempty"`
+ PathParameters []ApiPathParameter `json:"pathParameters,omitempty"`
+}
+
+type ApiPathParameter struct {
+ Name string `json:"name,omitempty"`
Review comment:
since `name` and `in` values are required, can the `omitempty` be removed
from these fields?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services