csantanapr commented on a change in pull request #95: remove swift:3 support
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/95#discussion_r153639957
##########
File path: kubernetes/controller/controller.yml
##########
@@ -54,7 +54,7 @@ spec:
# This needs to stay up to date with the lates runtime in Ansible
Groupvars
- name: "RUNTIMES_MANIFEST"
- value: '{ "defaultImagePrefix": "openwhisk", "defaultImageTag":
"latest", "runtimes": { "nodejs": [ { "kind": "nodejs", "image": { "name":
"nodejsaction" }, "deprecated": true }, { "kind": "nodejs:6", "default": true,
"image": { "name": "nodejs6action" }, "deprecated": false } ], "python": [ {
"kind": "python", "image": { "name": "python2action" }, "deprecated": false },
{ "kind": "python:2", "default": true, "image": { "name": "python2action" },
"deprecated": false }, { "kind": "python:3", "image": { "name": "python3action"
}, "deprecated": false } ], "swift": [ { "kind": "swift", "image": { "name":
"swiftaction" }, "deprecated": true }, { "kind": "swift:3", "image": { "name":
"swift3action" }, "deprecated": false }, { "kind": "swift:3.1.1", "default":
true, "image": { "name": "action-swift-v3.1.1" }, "deprecated": false } ],
"java": [ { "kind": "java", "default": true, "image": { "name": "java8action"
}, "deprecated": false, "attached": { "attachmentName": "jarfile",
"attachmentType": "application/java-archive" }, "sentinelledLogs": false,
"requireMain": true } ] }, "blackboxes": [ { "name": "dockerskeleton" } ] }'
+ value: '{ "defaultImagePrefix": "openwhisk", "defaultImageTag":
"latest", "runtimes": { "nodejs": [ { "kind": "nodejs", "image": { "name":
"nodejsaction" }, "deprecated": true }, { "kind": "nodejs:6", "default": true,
"image": { "name": "nodejs6action" }, "deprecated": false } ], "python": [ {
"kind": "python", "image": { "name": "python2action" }, "deprecated": false },
{ "kind": "python:2", "default": true, "image": { "name": "python2action" },
"deprecated": false }, { "kind": "python:3", "image": { "name": "python3action"
}, "deprecated": false } ], "swift": [ { "kind": "swift", "image": { "name":
"swiftaction" }, "deprecated": true }, { "kind": "swift:3", "image": { "name":
"swift3action" }, "deprecated": true }, { "kind": "swift:3.1.1", "default":
true, "image": { "name": "action-swift-v3.1.1" }, "deprecated": false } ],
"java": [ { "kind": "java", "default": true, "image": { "name": "java8action"
}, "deprecated": false, "attached": { "attachmentName": "jarfile",
"attachmentType": "application/java-archive" }, "sentinelledLogs": false,
"requireMain": true } ] }, "blackboxes": [ { "name": "dockerskeleton" } ] }'
Review comment:
what a mess to diff.
I changed `swift:3` kind to `"deprecated": true`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
