mrutkows commented on a change in pull request #46: Add retry support to every
request
URL:
https://github.com/apache/incubator-openwhisk-client-go/pull/46#discussion_r154109909
##########
File path: whisk/client.go
##########
@@ -316,98 +319,118 @@ func BodyTruncator(body io.ReadCloser) (string,
io.ReadCloser, error) {
return string(data), reload, nil
}
+func retry(attempts int, sleep time.Duration, callback func() (*http.Response,
error)) (*http.Response, error) {
+ var err error
+ var resp *http.Response
+ for i := 0; ; i++ {
+ resp, err = callback()
Review comment:
@houshengbo do we wish to retry on all errors? It seems that some are
"soft" errors that deserve retry (like concurrency) and others are "hard"
errors that will not produce different results on a retry (for example,
authorization failures).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
