abaruni commented on a change in pull request #229: verify trigger fire
responds with any successful status code
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/229#discussion_r154183037
##########
File path: provider/consumer.py
##########
@@ -353,8 +353,12 @@ def __fireTrigger(self, messages):
# Manually commit offset if the trigger was fired
successfully. Retry firing the trigger
# for a select set of status codes
- if status_code == 200:
- logging.info("[{}] Fired trigger with activation
{}".format(self.trigger, response.json()['activationId']))
+ if status_code in range(200, 300):
Review comment:
the lower bound is inclusive while the upper bound is exclusive. i checked ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
