rabbah commented on a change in pull request #3031: WIP: Return 202 for trigger
fire requests
URL:
https://github.com/apache/incubator-openwhisk/pull/3031#discussion_r154253829
##########
File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala
##########
@@ -143,9 +141,11 @@ trait WhiskTriggersApi extends WhiskCollectionAPI {
response = ActivationResponse.success(payload orElse
Some(JsObject())),
version = trigger.version,
duration = None)
+
logging.info(this, s"[POST] trigger activated, writing activation
record to datastore: $triggerActivationId")
- val saveTriggerActivation = WhiskActivation.put(activationStore,
triggerActivation) map { _ =>
- triggerActivationId
+ WhiskActivation.put(activationStore, triggerActivation) recover {
+ case t =>
+ logging.error(this, s"[POST] storing trigger activation
$triggerActivationId failed: ${t.getMessage}")
Review comment:
They won?t here. No worse than today. The subsequent improvements will
address this deficiency. You can see a sketch of the implementation here
https://github.com/apache/incubator-openwhisk/compare/master...rabbah:trigger-activations?expand=1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
