markusthoemmes commented on a change in pull request #2991: controller creates
health and cacheInvalidation topics
URL:
https://github.com/apache/incubator-openwhisk/pull/2991#discussion_r154938597
##########
File path:
common/scala/src/main/scala/whisk/connector/kafka/KafkaMessagingProvider.scala
##########
@@ -35,6 +35,17 @@ import whisk.core.connector.MessageConsumer
import whisk.core.connector.MessageProducer
import whisk.core.connector.MessagingProvider
+import pureconfig._
+
+case class TopicConfig(segmentBytes: Long, retentionBytes: Long, retentionMs:
Long) {
+ def toMap(): Map[String, String] = {
Review comment:
Drop the parentheses on `toMap`. It's not side-effecting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
